feat(studio): keyframes flag, gesture recording + timeline/selection refinements#1611
feat(studio): keyframes flag, gesture recording + timeline/selection refinements#1611miguel-heygen wants to merge 2 commits into
Conversation
james-russo-rames-d-jusso
left a comment
There was a problem hiding this comment.
Reviewed at 7268f634. Big PR by line count but it decomposes into orthogonal fixes (keyframe %-math, gesture-record runtime connect, URL state, selection refinements) — each lands cleanly with focused tests. Title still says "keyframes flag" but per the PR body and grep, the STUDIO_KEYFRAMES_ENABLED flag was introduced upstack in #1610 and remains default-false; this PR doesn't flip it. No soak-time concern — that's a non-issue here. Flag is consistently gated at every entry point I checked (TimelineToolbar L131, App.tsx L263/541/568, StudioPreviewArea L344, PropertyPanel 5 sites, propertyPanel3dTransform 2 sites, TimelineCanvas L432).
Looks good to me on the substantive fixes.
Concerns
• useEnableKeyframes.ts:339-341 — when selectedGsapAnimations is non-empty, the fetch-fallback is skipped. If the session cache is stale (e.g. just after a delete-all that lagged the parse), this proceeds with phantom anims and the resulting branch picks the wrong shape (the very class of bug the rest of this PR is fixing). The arcAnim/kfAnim/setAnim/flatAnim split papers over most stale shapes, but it doesn't help if the cache says "has keyframes" and disk says "no animations." Suggest: keep the cached-anims fast path, but in the no-match branches (line 365 else) re-fetch once before falling through to the create path, to avoid a doubled-create on stale data.
• useStudioUrlState.ts:152-174 — selection-hydration effect depends on currentTime, so it re-runs on every playhead tick until hydratedSelectionRef.current flips. The hydratedSelectionRef.current early-return is cheap but it's running through the whole effect graph on each render; consider gating with a top-level if (hydratedSelectionRef.current) return; AND dropping currentTime from deps in favor of a one-shot useEffect + a snapshot read. Cosmetic, but tightens the hot path.
• useGestureRecording.ts:399-401 — applyRuntimePreview failure → r.runtime = null silently. Recording continues without live preview, and the user gets no signal until commit (samples were still captured, but the gestural feedback they're chasing is gone). Suggest a one-shot console.warn so a dev/QA sees the runtime-disconnect cause in the console instead of silent dead-pixel preview.
• playerStore.ts:374-379 — window.__playerStore exposed unconditionally as a "bug-bash aid." Comparable to the iframe's __timelines/__player, so not a security concern (it's a Zustand handle, not state). Two thoughts: (1) gate behind import.meta.env.DEV so it's stripped from prod bundles, or (2) namespace under window.__hf.studio to match the other studio globals. Keep it if shipping intentionally; flag it in a ponytail comment with an expiry.
Nits
• useEnableKeyframes.ts:51-62 animatedProps() — falls back to ["x","y"] for unanimated elements. Sensible default, but promoteSetToKeyframes at L242-243 reads end position via this, so a set({rotation: 90}) followed by "add keyframe at playhead" would emit {x, y, rotation} keyframes instead of just {rotation, …}. Probably benign because gsap.getProperty returns the runtime value, but the resulting two-stop tween will carry position keyframes for a rotation-only set. Worth a sibling test or a tighter prop-source. (nit)
• KeyframeNavigation.tsx:38-43 — mapped[0]! / mapped[mapped.length-1]! non-null asserts. The length < 2 guard already proves these are present; consider a const [first, last] destructure to remove the !s. (nit)
• RenderQueue.tsx:122 — copy now reads "Final Cut Pro, DaVinci Resolve, and most video editors" — fine, but the CapCut and Premiere removals lose some discoverability for users explicitly searching for those tools. Was that a deliberate signal or just trimming? (nit/question)
• index.html root gets data-hf-id="hf-aph5" — unclear why the studio shell root needs an hf-id; the comment in NLELayout suggests it's for composition-id wiring, but the studio root isn't a composition. (question)
Questions
• useGestureCommit.ts:200-210 — add-with-keyframes without propertyGroup when there's no existing position tween but the gesture's hasPositionProps is true. If the gesture also recorded rotation/scale (modifier mid-gesture), all those properties land in a single new tween without a propertyGroup. Does the upstream parser later split this, or does it become a legacy mixed tween that the bridge then splits at the next drag? Either is fine, but worth tracing.
• gsapSoftReload.ts:166-168 — pluginScript.onerror = () => executeScript() runs the script even when the MotionPathPlugin CDN fails to load. The inner script throws once it hits MotionPathPlugin, but deferredToAsync=true already short-circuited verifyTimelinesPopulated — so caller thinks the soft-reload succeeded while the timeline is gone. Is this intentional (full reload on next edit would recover) or should we fall back to a full reload on plugin error?
What I didn't verify
• Behavior in offline/CDN-blocked envs (the MotionPathPlugin CDN fetch).
• That the hashchange listener in useStudioUrlState cleanly transfers selection across cross-composition deep links (only same-project path covered in code review).
• useEnableKeyframes happy path against a real fixture with the update-meta extend on an arc — only unit-tested branches.
— Rames D Jusso
vanceingalls
left a comment
There was a problem hiding this comment.
Reviewed at 7268f634. Concur with @james-russo-rames-d-jusso — big PR by LOC but decomposes cleanly into orthogonal fixes (keyframe %-math, gesture-record runtime connect, URL state, selection refinements), each with focused tests.
Verified at HEAD:
STUDIO_KEYFRAMES_ENABLEDflag was introduced upstack in #1610 and remains default-false; this PR doesn't flip it. No new gating flag introduced — decorative-gate-pattern N/A. Consistent gating at every entry point Rames enumerated (TimelineToolbar, App.tsx, StudioPreviewArea, PropertyPanel, propertyPanel3dTransform, TimelineCanvas).- All four new exports tested:
clipToTweenPercentage(3 tests),resolveNewTweenRange(4),animatedProps(4),isPlayheadWithinTween(3),buildExtendedKeyframes(2). AuxiliaryfindTimelineIdByAncestor,coversComposition, expanded-children hash-form keying also covered. hashchangelistener atuseStudioUrlState.tshas matchingremoveEventListenercleanup (line 1192). No leak.
Concur with @james-russo-rames-d-jusso (verified each at HEAD):
useEnableKeyframes.ts:339-341stale-cache fetch-fallback skip: whenselectedGsapAnimationsis non-empty, no re-fetch on the no-match branches. Stale cache → wrong shape. Same bug class this PR is fixing. NIT-level follow-up; Rames's fix shape (re-fetch once in the no-matchelsebefore falling through to the create path) is right.useStudioUrlState.ts:152-174selection-hydration on every playhead tick:hydratedSelectionRef.currentearly-return saves it, but the effect graph runs through on each render. Top-levelif (hydratedSelectionRef.current) return;+ droppingcurrentTimefrom deps tightens the hot path. Cosmetic.useGestureRecording.ts:399-401silent runtime-disconnect:applyRuntimePreviewfailure →r.runtime = nullwith no signal to the user. One-shotconsole.warnwould surface this in dev/QA.playerStore.ts:374-379window.__playerStoreunconditional exposure: comparable to iframe globals, not a security concern, but worth gating behindimport.meta.env.DEVor namespacing underwindow.__hf.studioto match other studio globals.
Rest of Rames's nits also concur (mapped[0]! non-null asserts unnecessary given length < 2 guard; RenderQueue.tsx copy change; index.html data-hf-id="hf-aph5" question).
Note on facade-await regression carryover (cross-stack):
useEnableKeyframes.ts adds new session.commitMutation calls in this PR. Each is followed by return; with no post-action that depends on save-complete semantics. So this PR's NEW callsites don't exercise the HF #1558 shape. But the existing useGestureCommit.ts:127-212 (touched as part of the gesture-recording rewrite stack-wide, not this PR specifically) DOES — see my #1608 review for the broken-facade scope expansion. Not introduced by #1611; not fixed by #1611. Fix lands at #1608.
Verdict: NIT. No band-aid blockers, no test-touch-without-test-add, dispatch chain clean. The four follow-up items are improvements not regressions.
Review by Via
…hydration, dev-gated debug + gesture warn, per-group gesture tweens - useEnableKeyframes: parse current source first (null-vs-[] distinction) so a delete-all's empty parse isn't overridden by a stale selectedGsapAnimations cache. - useStudioUrlState: freeze the hydration effect's time dep once hydrated (was re-running every tick). - useGestureRecording: dev-gated console.warn when the live-preview runtime throws (was silent). - playerStore: gate window.__playerStore behind dev (guarded import.meta.env.DEV). - useGestureCommit: partition recorded keyframes by property group → one add-with-keyframes per group, so a mixed gesture no longer yields an untagged legacy tween.
0e07ce2 to
0392a98
Compare
7268f63 to
151f36b
Compare
…softReload onerror, tighten runtime ladder, per-group gestures - DROP STUDIO_GSAP_DRAG_INTERCEPT_ENABLED: single-source GSAP intercept is the only position/rotation channel; the false branch silently killed drag+rotate (and let GSAP elements into the keyframe-corrupting CSS path). Removed flag + dead branch + env def + tests. - gsapSoftReload: plugin onerror no longer fakes success — signals onAsyncFailure so the caller full-reloads; honors __hfMotionPathPluginLoading so a concurrent reload can't queue a dup script. - gsapDragCommit: resolveDragRuntime narrows the as-any ladder; a mid-seek throw logs + drops partial reads (no phantom identity) and re-applies the drag override in finally. - MotionPathOverlay: park-timer cleanup keyed on animId change. - useGestureCommit: partitionKeyframesByGroup wraps the add-with-keyframes sites (per #1611 review).
|
Subsumed by #1605 (retargeted to main with the full stack) |
* chore(producer): shim __filename/__dirname in the CJS banner Bundled CJS deps like wawoff2 call __dirname; without the shim they throw "__dirname is not defined in ES module" at render time. Also ignore .zed/. * chore(producer): use a template literal for the CJS banner (review nit) * feat(core): add GSAP keyframe + motion-path source mutations Array-form keyframe removal in both the recast and acorn writers, plus update/add/remove-motion-path-point and add-motion-path. Exclude _auto and data from tween property-group classification. * fix(core): address #1554 review — data-exclusion test, split-fix doc, motion-path sentinel, parity blocks - Regression test for the `data` GSAP-key exclusion (parallel to _auto). - splitAnimationsInScript: documented that .fromTo()/.to() correctly stay out of the from-branch (only .from() reverts) and the <= boundary; added mid-flight straddle tests. - addMotionPathToScript failure path returns id: null (was empty-string sentinel); caller updated. - Parity blocks for addKeyframeToScript array-form + updateKeyframeInScript (mirroring removeKeyframeFromScript). Surfaced a latent acorn array-form partial-props merge bug — documented as it.skip with a ready assertion (acorn cutover follow-up). * feat(core): route motion-path mutations through studio-api + fix clip stamping Wire the new mutations into the file save route. Only authored clips suppress descendant stamping, so auto-stamped animated scenes can inline-expand. Hide in-flow timed clips with `display:none` only when they are LEAF clips (no nested timed clips). `display:none` on a container removes its whole subtree, hiding descendants that are still inside their own visibility window — e.g. an in-flow composition root whose effective window clamps to the timeline end would black out a child video that should still show (the hdr-hlg regression). Containers keep `visibility:hidden`, which a visible descendant can override; only leaves leave the flow, which is all the split-overlap case needs. * feat(core): strip legacy path-offset/rotation + drop obsolete studio lint rule A position or rotation add/set mutation makes the GSAP timeline the single source of truth for that channel, so any lingering --hf-studio-offset / --hf-studio-rotation CSS var must be cleared to avoid double-applying. stripStudioEditsFromTarget now clears both channels, and the add-strip fires for the position AND rotation property groups. Also removes the obsolete `gsap_studio_edit_blocked` lint rule: it warned that Studio cannot save drag/resize edits to elements in a registered timeline — the exact premise the single-source work inverts (the timeline is now the edit target). Removed the rule, its now-unused TIMELINE_REGISTRY_ASSIGN_PATTERN import, and its 5 tests. * fix(core): address #1555 review — complete hold-sync, invalidate clip cache, strip rotation channel - HOLD_SYNC_MUTATION_TYPES: add add-motion-path (load-bearing — addMotionPathToScript authors past t=0 → first-frame snap-to-(0,0) without the hold), update-meta, shift-positions, scale-positions, split-animations. (add stays out: flat tweens only, syncPositionHoldsBeforeKeyframes is a no-op for non-keyframed tweens.) - init.ts: timedClip in-flow/leaf WeakMaps now invalidate on clipTreeSignature change; visible/hidden branches both go through isTimedClipInFlow (was .get() by accident). - keyframesWriteRotation mirrors keyframesWritePosition so a rotation-only keyframe set strips the stale --hf-studio-rotation channel. * feat(studio): GSAP runtime read layer + shared helpers * fix(studio): address #1607 review — cold-parse vs fetch-error budgets, isZeroDurationSet, array-ease tests - useGsapAnimationFetchFallback: discriminate resolved/fetch-error/cold; only the cold (warm-but-zero) race gets the full ~600ms retry budget — a hard fetch error retries once. - Extract isZeroDurationSet (was !(duration>0) duplicated); rejects NaN, documents intent. - parsePercentageKeyframes: cite GSAP even-index spread; tests that a per-entry/interior ease is stripped without shifting the other keyframes' percentages. * feat(studio): GSAP drag/commit/bridge editing infra * fix(studio): address #1608 review — facade awaits commit, strict stale-parse guard, clearProps restore BLOCKER: useSafeGsapCommitMutation now RETURNS the (.catch-chained) commit promise and the commitMutation facade awaits it — so await session.commitMutation(...) resolves AFTER the server save, fixing both consumers (useEnableKeyframes + useGestureCommit's showToast/requestSeek/idle, which were firing before the save landed). SafeGsapCommitMutation return type widened void→Promise<void> (fire-and-forget consumers ignore it). - stale-parse guard uses hasNonHoldTweenForElement (a leftover hold set no longer counts as live). - commitFlatViaKeyframes snapshots dragged gsap values before clearProps + restores after seek, so a failed commit leaves the dropped pose, not a cleared element. * feat(studio): motion-path geometry + commit helpers * docs(studio): address #1609 review — document occlusion fade-in invariant, donut limit, nearestPointOnPath t-semantics * feat(studio): on-canvas motion-path overlay * fix(studio): address #1610 review — scope dblclick to pan-surface, kind-aware geometry guard, gate createMode, screen-space drag threshold * feat(studio): keyframes flag, gesture recording + timeline/selection refinements * fix(studio): address #1611 review — fetch-first keyframe path, gated hydration, dev-gated debug + gesture warn, per-group gesture tweens - useEnableKeyframes: parse current source first (null-vs-[] distinction) so a delete-all's empty parse isn't overridden by a stale selectedGsapAnimations cache. - useStudioUrlState: freeze the hydration effect's time dep once hydrated (was re-running every tick). - useGestureRecording: dev-gated console.warn when the live-preview runtime throws (was silent). - playerStore: gate window.__playerStore behind dev (guarded import.meta.env.DEV). - useGestureCommit: partition recorded keyframes by property group → one add-with-keyframes per group, so a mixed gesture no longer yields an untagged legacy tween. * feat(studio): single-source manual offset + rotation via the GSAP timeline Dragging or rotating an element writes into the GSAP timeline (the single source of truth) instead of a parallel --hf-studio-offset / --hf-studio-rotation CSS var: static elements commit a tl.set (idempotent on re-edit), tweened elements edit keyframes, and the live preview moves via gsap.set so what you see equals what is written and renders. Removes the dual-channel CSS-var/transform reconciliation behind the fling / disappear / runaway / double-stack / wrong-start bug class — for BOTH position and rotation (gesture base read from the gsap transform, gsap.set live preview, tl.set/ keyframe commit, dropped the handleDom*Commit CSS fallbacks). Subcompositions edit the same single-source way, which surfaced and fixes: - resolve a subcomp element's source file via the composition-id map (the runtime drops the source linkage when inlining the subcomposition); - a selected element's selection box AND motion path use basic visibility, not the occlusion heuristic (a backgroundless opacity-1 scene above it is not an opaque cover); - soft reload rebuilds ONLY the committed composition's timeline, leaving other compositions' timelines intact (no cross-composition revert); - read keyframes from the element's OWN composition timeline (scan all timelines, not the first unstable key); - delete-all uses a soft reload too, so editing no longer hard-reloads the iframe. * fix(studio): address #1567 review — drop drag-intercept flag, harden softReload onerror, tighten runtime ladder, per-group gestures - DROP STUDIO_GSAP_DRAG_INTERCEPT_ENABLED: single-source GSAP intercept is the only position/rotation channel; the false branch silently killed drag+rotate (and let GSAP elements into the keyframe-corrupting CSS path). Removed flag + dead branch + env def + tests. - gsapSoftReload: plugin onerror no longer fakes success — signals onAsyncFailure so the caller full-reloads; honors __hfMotionPathPluginLoading so a concurrent reload can't queue a dup script. - gsapDragCommit: resolveDragRuntime narrows the as-any ladder; a mid-seek throw logs + drops partial reads (no phantom identity) and re-applies the drag override in finally. - MotionPathOverlay: park-timer cleanup keyed on animId change. - useGestureCommit: partitionKeyframesByGroup wraps the add-with-keyframes sites (per #1611 review). * feat(studio): patchRuntimeTweenInPlace — update a tween's values in place Defensive runtime helper: locate the element's tween in window.__timelines via the shared resolveRuntimeTween scan, update its set/keyframe vars, invalidate, and re-seek the playhead — without re-running the whole composition. Returns false (caller falls back to soft reload) for any shape it can't safely patch (no tween, dynamic/computed keyframes, motionPath arc, channel mismatch, or any error). Foundation for instant, flicker-free manual edits. * fix(studio): address #1612 review — channel-aware set resolution + decline dynamic-expression patches - resolveRuntimeTween gains an optional channels[] hint; for kind:set it prefers the set whose vars carry one of the patched channels and never returns a disjoint-only set (e.g. won't write {x,y} into a co-located {rotation} set). patchRuntimeTweenInPlace derives channels from the props. - patchSet declines (returns false → soft reload) when overwriting a string/dynamic vars[ch], instead of silently dropping the computed expression. * feat(studio): instantPatch fast path in runCommit A commit carrying an instantPatch option tries patchRuntimeTweenInPlace first; on success the preview updates in place with NO reload (instant), on false it falls back to the existing soft reload. Extracts the preview-sync tail into a testable applyPreviewSync helper. No behavior change when instantPatch is absent. * feat(studio): route static position/rotation set drags through instantPatch Static-element position and rotation set commits now attach instantPatch{selector, change:{kind:set}} so the drag updates in place with no reload. Structural ops (new tween add, delete-all, convert/split/materialize) and keyframe edits deliberately omit it and keep the soft reload — keyframe instant-patch needs object-form keyframe support in patchRuntimeTweenInPlace (deferred). * fix(studio): address #1613 review — derive instantPatch from the mutation, patch both coalesced commits, wire onAsyncFailure - commitStaticGsapPosition/Rotation derive instantPatch.change.props from the actual update-property mutation(s) sent (one source of truth → findUnsafeMutationValues-validated values flow into the patch; can't drift). - Coalesced x/y: the intermediate x commit also carries instantPatch{x}, the y commit {x,y}, so a second-POST failure still leaves the preview patched for what persisted. - applyPreviewSync passes reloadPreview as onAsyncFailure (plugin-CDN load error → full reload); per U4 the synchronous false still does NOT escalate. - (channel disambiguation from #1612 verified end-to-end: {x,y}→position set, {rotation}→rotation set.) * feat(studio): no full iframe remount for soft-reloadable edits A softReload edit (and the SDK single-script refresh) no longer escalates to a full reloadPreview() iframe remount when applySoftReload returns false — the live gsap.set already shows the value, and a remount is the worst flash + re-inlines subcomps (reverting their keyframes). verifyTimelinesPopulated now checks the expected target keys the re-run registers, so a correct scoped re-run doesn't spuriously report empty. Full reload stays only for the structural (no-softReload) and ambiguous-script paths. * feat(studio): pre-load MotionPathPlugin so motion-path edits don't async-flash ensureMotionPathPluginLoaded() runs once at the preview iframe-load seam (NLELayout onIframeLoad), eagerly loading + registering MotionPathPlugin without killing the timeline. So when a user adds a motion path to a composition that didn't originally use one, the soft reload runs synchronously instead of taking the kill-then-await-CDN async path (the flash). Idempotent + defensive; the existing async fallback stays for genuine cold-start/CDN-failure. * fix(studio): don't re-save + reload when source editor syncs externally The SourceEditor's CodeMirror update listener fired onChange on ANY docChanged — including the programmatic dispatch that syncs external content (e.g. a manual-edit commit writing the source back into the open editor). That made the editor re-save the file and bump refreshKey, fully reloading the preview iframe on every drag/keyframe edit — defeating the in-place instant patch and causing the flash. Annotate the programmatic sync (ExternalSync) and skip onChange for it, so only real keystrokes save. * fix(core): inject MotionPathPlugin into preview when a composition uses motionPath A studio-created motion path writes a gsap motionPath tween into the single-source timeline, but the preview HTML only loaded gsap core — so the first render threw "Invalid property motionPath ... Missing plugin?". Detect motionPath usage and inject MotionPathPlugin right after the composition's gsap script, version-matched to it. * fix(studio): dedup __hfMotionPathPluginLoading type decl (restack artifact) * fix(studio): address #1605 review — distinguish soft-reload failure modes + observability, SourceEditor focus guard BLOCKER: applySoftReload now returns SoftReloadResult ('applied' | 'verify-failed' | 'cannot-soft-reload') instead of a bare bool. applyPreviewSync + sdkRefresh escalate to a full reloadPreview() on the PERMANENT 'cannot-soft-reload' (no gsap/rebind hook/scopable key/script, or sync re-run threw) — fixing the silent-stale-preview U4 dropped — but still suppress the TRANSIENT 'verify-failed' (live gsap.set is correct). Telemetry: gsap_soft_reload_outcome (origin/result/escalated) + gsap_instant_patch_fallback, so the U4 invariant is enforced, not asserted. - SourceEditor: skip the programmatic external-sync replace while the editor is focused, so an in-flight commit doesn't clobber the user's uncommitted keystrokes (ExternalSync kept for unfocused). - Verified ensureMotionPathPluginLoaded already guards __hfMotionPathPluginLoading (no double-append). * fix(core): align __clipTree and __clipManifest ids via stableClipId Timeline inline expansion was dead for nested children inside index.html: the tree keyed id-less elements by a synthetic __clip-N while the manifest keyed them null, so parent<->child never joined. Both now resolve identity through stableClipId (id || data-hf-id), which every generated element has. * fix(core): strip baked runtime + tag comp root in preview assembly Comps that ship a baked inline runtime were double-loaded (preview injects its own) and the baked copy failed to parse inline (Unexpected token '<'). Strip it in buildSubCompositionHtml + the disk-fallback preview path. Also tag the comp root with data-composition-file so the studio resolves a comp's top-level elements to the right source file instead of defaulting to index.html (which made the GSAP panel parse the wrong, multi-timeline file). * feat(studio): set motion-path destination from a toolbar toggle Replaces the double-click-on-canvas UX (which painted text over the preview) with a 'Set motion destination' toggle next to Snap/Grid, shown only when the selected element can take a path. While armed, one canvas press places the destination. Also removes the dead TimelinePropertyRows component. * fix(studio): center timeline keyframe diamonds on their percentage Dropped clampDiamondLeft, which forced boundary keyframes fully inside the clip so a 0% diamond sat half a diamond right of the 0% point. Each diamond's midpoint now sits exactly on its % (the clip is overflow-visible). * fix(studio): resize static elements via tl.set, not a single-stop keyframes tween Resizing an element with no size animation wrote keyframes:{ <playhead%>: {width,height} } — one mid-point stop GSAP can't interpolate, so it rendered NaN/0 dimensions at every other frame and the element vanished (worst off 0%). Added commitStaticGsapSize (mirrors commitStaticGsapPosition): a static resize now writes tl.set({width,height}), held at all frames; re-resizing updates it in place. * fix(studio): negative-cache failed media probes Only successful probes were cached, so CORS/404 cross-origin media was re-probed every rAF-driven timeline re-derive, flooding the console. Remember failed URLs and skip them. * fix(studio): type window.setTimeout handle as number ReturnType<typeof window.setTimeout> infers NodeJS.Timeout when @types/node is present and clashes with the DOM number the call returns. Type it number. * fix(studio): drag/resize disappearance, stale-ID duplicates, soft-reload clearProps - Fix soft-reload clearProps destroying element inline styles — save cssText, clear, restore, strip only transform - Fix resize no-op on re-resize: delete+add instead of two update-property - Route set tweens through static resize path (convertToKeyframes skips sets) - Re-fetch animation ID before drag commit to prevent stale-ID duplicates - Guard editDebugLog for Node test environments - Fix NLELayout setState-during-render (move reset to useEffect) - Stop SnapToolbar pointer events propagating to canvas deselect handler - Enable click-to-add waypoints on cubic motion paths - Add whole-path drag offset (Alt+drag shifts all keyframes together) - Add Canvas shortcuts section to ShortcutsPanel - Extract useMotionPathData + commitGsapPositionFromDrag (filesize compliance) - Delete dead code (getElementDepth, isElementVisibleInPreview, unused exports)

Summary
This is the top studio-foundation PR in the GSAP keyframe / motion-path stack. It hardens the keyframe-editing surface and fixes a cluster of bugs across keyframe add/remove, gesture recording, deep-link URL state, and canvas selection. Headline fixes: keyframe mutations now key on the correct (tween-relative) percentage so they land on disk instead of silently no-op'ing; gesture recording connects to the real timeline and records the full on-screen position so committed gestures play back where they were drawn; deep links (
?t=, element, panel tab) hydrate and respond to external navigation; and full-bleed scene wrappers no longer hijack canvas click-picking.No new user-facing flag is introduced — "keyframes flag" refers to the keyframe affordances gated behind the existing inspector surface.
What's changed
Keyframe add / remove correctness (
useEnableKeyframes.ts,KeyframeNavigation.tsx,TimelineToolbar.tsx)%and missed every keyframe (a silent no-op the optimistic cache hid). NewclipToTweenPercentage()recovers the clip→tween map from the keyframes' own(percentage, tweenPercentage)pairs.useEnableKeyframesrewritten into typed branches:applyArcWaypointAtPlayhead(arc/motionPath edited as waypoints vianearestPointOnPath, range-extend viaupdate-meta,WAYPOINT_MERGE_PXguard);applyKeyframeAtPlayhead(native keyframes — toggle/add/extend);promoteSetToKeyframes(aset()→ two-stop tween); flatto/from/fromToconverted to natural keyframes then routed uniformly.animatedProps(),isPlayheadWithinTween(),buildExtendedKeyframes()(grows range while rescaling stops to preserve absolute timing),resolveNewTweenRange()(clamps the playhead into range so a new keyframe lands at the playhead despite the runtime auto-stamping start=0/duration=root).opacityso the new tween is position-only.Gesture recording (
useGestureRecording.ts)connectGsapRuntimepicks the first__timelinesentry that is an actual timeline (typeof value.seek === "function"), skipping the__proxiedmarker (the no-live-preview bug).recordSampleno longer subtracts the CSS-var/pointer-snap offset (the server strips--hf-studio-offseton commit; subtracting shoved gestures off by the offset twice).clearPropsteardown before re-applying the offset.URL / deep-link state (
useStudioUrlState.ts,useTimelineSyncCallbacks.ts,playerStore.ts)hashchangelistener re-applies URL state on external navigations (pasted link, back/forward); extracted sharedapplyUrlSelection().useTimelineSyncCallbacksreconcilespendingSeekRef ?? store.requestedSeekTimewhen the adapter becomes ready so a deep-linked?t=lands instead of starting at 0.setSelectedElementIddrops any active keyframe selection on element change; added awindow.__playerStoreread handle for bug-bash inspection.Selection refinements (
studioPreviewHelpers.ts,studioHelpers.ts,useDomSelection.ts,useExpandedTimelineElements.ts,useStudioContextValue.ts,StudioHeader.tsx)coversComposition()(95% both axes, degenerate-viewport guard) excludes scene wrappers from canvas click-picking (Layers panel still selects them).findTimelineIdByAncestor()walks up from a static descendant to its nearest clip ancestor.<sourceFile>#<domId>) viabuildTimelineElementKeysoisSelectedmatches.Other
NLELayoutpreview getsoverflow-hidden;useRazorSplitforwardselementStart/elementDuration;RenderQueuecopy trimmed;index.htmlroot gains adata-hf-id.Why
The keyframe editor was silently failing in the common case (clip-relative % never matched the on-disk tween-relative keyframes, masked by the optimistic cache). Gesture recording had no live preview (grabbed the
__proxiedmarker) and committed gestures shifted by the path offset. Deep links didn't seek or restore selection. Full-bleed wrappers made the canvas hard to use. This PR makes each path correct with regression coverage.Testing
bun run build+bun run test(studio). New/extended Vitest suites:useEnableKeyframes.test.ts(new) —resolveNewTweenRange,animatedProps,isPlayheadWithinTween,buildExtendedKeyframes(extend + rescale to preserve absolute timing).KeyframeNavigation.test.ts(new) —clipToTweenPercentagemaps anchors, interpolates an interior playhead, falls back with <2 anchors.useExpandedTimelineElements.test.ts— expanded children keyed in hash form (index.html#eyebrow).studioHelpers.test.ts—findTimelineIdByAncestor(resolves.num→#stat1;nullwhen no clip ancestor); switched tohappy-dom.studioPreviewHelpers.test.ts—coversComposition(full-bleed covers; inner/wide-short/tall-narrow do not; needs both axes ≥95%; degenerate guard).Stack
Part of the GSAP keyframe/motion-path stack:
#1553 → #1554 → #1555 → #1607 → #1608 → #1609 → #1610 → #1611 → #1567 → #1612 → #1613 → #1605. Top studio-foundation PR, on #1610. Builds independently; the combined diff is byte-identical to the originally-reviewed work.